Module:Rocketry - Revision history

RA2lover: fix GetCombustionTemperature not being idempotent

2026-03-27T14:04:42Z

fix GetCombustionTemperature not being idempotent

← Older revision		Revision as of 14:04, 27 March 2026
Line 29:		Line 29:

	--add uncombusted contents to reaction outputs		--add uncombusted contents to reaction outputs

			--We need a copy of the table as writing to the original reactiondata table contaminates it.
			local newreactiondata={}
			for k,v in pairs(reactiondata) do
			newreactiondata[k] = v
			if type(v) == "table" then
			newreactiondata[k] = {}
			for k2,v2 in pairs(v) do
			--it's okay to pass the gas table as a reference as we're only reading it.
			newreactiondata[k][k2]=v2
			end
			end
			end

	if combustionRatio < 1 then		if combustionRatio < 1 then
	table.insert(~~reactiondata~~.Outputs,		table.insert(newreactiondata.Outputs,
	{		{
	Gas = Gas.GetGas(fuel),		Gas = Gas.GetGas(fuel),
	Amount = ~~reactiondata~~.FuelAmount*(1-combustionRatio)		Amount = newreactiondata.FuelAmount*(1-combustionRatio)
	}		}
	)		)
	table.insert(~~reactiondata~~.Outputs,		table.insert(newreactiondata.Outputs,
	{		{
	Gas = Gas.GetGas(oxidizer),		Gas = Gas.GetGas(oxidizer),
	Amount = ~~reactiondata~~.OxidizerAmount*(1-combustionRatio)		Amount = newreactiondata.OxidizerAmount*(1-combustionRatio)
	}		}
	)		)
Line 47:		Line 60:
	--calculate Heat Capacity of reaction output		--calculate Heat Capacity of reaction output
	local OutputHeatCapacity = 0		local OutputHeatCapacity = 0
	for k,v in pairs(~~reactiondata~~.Outputs) do		for k,v in pairs(newreactiondata.Outputs) do
	OutputHeatCapacity = OutputHeatCapacity + (v.Gas.SpecificHeat * v.Amount)		OutputHeatCapacity = OutputHeatCapacity + (v.Gas.SpecificHeat * v.Amount)
	end		end

	return TotalEnergy / OutputHeatCapacity, ~~reactiondata~~ --i'll want that later on for exhaust velocity because of heat capacity ratio.		return TotalEnergy / OutputHeatCapacity, newreactiondata --i'll want that later on for exhaust velocity because of heat capacity ratio.

	end		end

RA2lover: change log to warn type, make combustion take multiple fuel moles into account

2026-03-27T13:35:51Z

change log to warn type, make combustion take multiple fuel moles into account

← Older revision		Revision as of 13:35, 27 March 2026
Line 9:		Line 9:

	local EnthalpyMultiplier = 1		local EnthalpyMultiplier = 1
	fuelTemperature = fuelTemperature or 0		fuelTemperature = fuelTemperature or 100
	oxidizerTemperature = oxidizerTemperature or 0		oxidizerTemperature = oxidizerTemperature or 100
	combustionRatio = combustionRatio or 0.96		combustionRatio = combustionRatio or 0.96

Line 23:		Line 23:

	local FuelEnthalpy = Gas.GetGas(fuel).Enthalpy		local FuelEnthalpy = Gas.GetGas(fuel).Enthalpy
	local FuelHeatEnergy = Gas.GetGas(fuel).SpecificHeatfuelTemperaturereactiondata.FuelAmount		local FuelHeatEnergy = (Gas.GetGas(fuel).SpecificHeatfuelTemperature)reactiondata.FuelAmount
	local OxidizerHeatEnergy = Gas.GetGas(oxidizer).SpecificHeatoxidizerTemperaturereactiondata.OxidizerAmount		local OxidizerHeatEnergy = (Gas.GetGas(oxidizer).SpecificHeatoxidizerTemperature)reactiondata.OxidizerAmount
	local CombustionEnergy = FuelEnthalpycombustionRatioEnthalpyMultiplier		local CombustionEnergy = FuelEnthalpyreactiondata.FuelAmountcombustionRatio*EnthalpyMultiplier
	local TotalEnergy = FuelHeatEnergy + OxidizerHeatEnergy + CombustionEnergy		local TotalEnergy = FuelHeatEnergy + OxidizerHeatEnergy + CombustionEnergy

Line 69:		Line 69:
	if type(heatcapacityratio) == "string" then heatcapacityratio = tonumber(heatcapacityratio) end		if type(heatcapacityratio) == "string" then heatcapacityratio = tonumber(heatcapacityratio) end
	if type(heatcapacityratio) ~= number then		if type(heatcapacityratio) ~= number then
	mw.~~Log~~("WARN: UNABLE TO PARSE HEAT CAPACITY RATIO. ASSUMING TriatomicHeatCapacityRatio")		mw.log.warn("WARN: UNABLE TO PARSE HEAT CAPACITY RATIO. ASSUMING TriatomicHeatCapacityRatio")
	heatcapacityratio = GasData.TriatomicHeatCapacityRatio		heatcapacityratio = GasData.TriatomicHeatCapacityRatio
	end		end

RA2lover: Created page with "local Gas = require("Module:Gas") local Combustion = require("Module:Combustion") local CombustionData = require("Module:Combustion/data") local GasData = mw.loadData("Module:Gas/data") local p = {} function p.GetCombustionTemperature(fuel, oxidizer, reactiondata, combustionRatio, fuelTemperature, oxidizerTemperature) local EnthalpyMultiplier = 1 fuelTemperature = fuelTemperature or 0 oxidizerTemperature = oxidizerTemperature or 0 combustionRatio = combustionRatio or..."

2026-03-27T13:15:39Z

Created page with "local Gas = require("Module:Gas") local Combustion = require("Module:Combustion") local CombustionData = require("Module:Combustion/data") local GasData = mw.loadData("Module:Gas/data") local p = {} function p.GetCombustionTemperature(fuel, oxidizer, reactiondata, combustionRatio, fuelTemperature, oxidizerTemperature) local EnthalpyMultiplier = 1 fuelTemperature = fuelTemperature or 0 oxidizerTemperature = oxidizerTemperature or 0 combustionRatio = combustionRatio or..."

New page

local Gas = require("Module:Gas")
local Combustion = require("Module:Combustion")
local CombustionData = require("Module:Combustion/data")
local GasData = mw.loadData("Module:Gas/data")

local p = {}

function p.GetCombustionTemperature(fuel, oxidizer, reactiondata, combustionRatio, fuelTemperature, oxidizerTemperature)

local EnthalpyMultiplier = 1
fuelTemperature = fuelTemperature or 0
oxidizerTemperature = oxidizerTemperature or 0
combustionRatio = combustionRatio or 0.96

if not outputs then
if not oxidizer then
reactiondata = CombustionData[fuel]
else
reactiondata = CombustionData[fuel][oxidizer]
EnthalpyMultiplier = Gas.GetGas(oxidizer).EnthalpyMultiplier
end
end

local FuelEnthalpy = Gas.GetGas(fuel).Enthalpy
local FuelHeatEnergy = Gas.GetGas(fuel).SpecificHeat*fuelTemperature*reactiondata.FuelAmount
local OxidizerHeatEnergy = Gas.GetGas(oxidizer).SpecificHeat*oxidizerTemperature*reactiondata.OxidizerAmount
local CombustionEnergy = FuelEnthalpy*combustionRatio*EnthalpyMultiplier
local TotalEnergy = FuelHeatEnergy + OxidizerHeatEnergy + CombustionEnergy

--add uncombusted contents to reaction outputs

if combustionRatio < 1 then
table.insert(reactiondata.Outputs,
{
Gas = Gas.GetGas(fuel),
Amount = reactiondata.FuelAmount*(1-combustionRatio)
}
)
table.insert(reactiondata.Outputs,
{
Gas = Gas.GetGas(oxidizer),
Amount = reactiondata.OxidizerAmount*(1-combustionRatio)
}
)
end

--calculate Heat Capacity of reaction output
local OutputHeatCapacity = 0
for k,v in pairs(reactiondata.Outputs) do
OutputHeatCapacity = OutputHeatCapacity + (v.Gas.SpecificHeat * v.Amount)
end

return TotalEnergy / OutputHeatCapacity, reactiondata --i'll want that later on for exhaust velocity because of heat capacity ratio.

end

function p.GetExhaustVelocity(engineEfficiency, combustiontemperature, heatcapacityratio)
if not heatcapacityratio then heatcapacityratio = GasData.TriatomicHeatCapacityRatio end
if type(heatcapacityratio) == "table" and type(heatcapacityratio.Outputs) == "table" then
--calculate heat capacity ratio by averaging out the heat capacity ratio of exhaust composition
local TotalMoles = 0
local TotalMolarHeatCapacityRatio = 0
for k,v in pairs(heatcapacityratio.Outputs) do
TotalMoles = TotalMoles + v.Amount
TotalMolarHeatCapacityRatio = TotalMolarHeatCapacityRatio + (v.Amount * v.Gas.HeatCapacityRatio)
end
heatcapacityratio = TotalMolarHeatCapacityRatio/TotalMoles
end
if type(heatcapacityratio) == "string" then heatcapacityratio = tonumber(heatcapacityratio) end
if type(heatcapacityratio) ~= number then
mw.Log("WARN: UNABLE TO PARSE HEAT CAPACITY RATIO. ASSUMING TriatomicHeatCapacityRatio")
heatcapacityratio = GasData.TriatomicHeatCapacityRatio
end

return 25*engineEfficiency*((8.3144*heatcapacityratio*combustiontemperature)^0.5)

end
function p.GetThrust(ExhaustVelocity, MassFlowRate)
if type(MassFlowRate) == "table" and type(MassFlowRate.Outputs) == "table" then
--calculate the molar mass of exhaust composition
local TotalMoles = 0
for k,v in pairs(heatcapacityratio.Outputs) do
TotalMoles = TotalMoles + v.Amount
end
MassFlowRate = TotalMoles
end
return 2*ExhaustVelocity*MassFlowRate --2 ticks/second; MassFlowRate is given in mols/tick.
end

return p